feat(AnimeDrive): add support for iFrame and Hungarian description #8343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FeriVOQ <[email protected]>
Signed-off-by: FeriVOQ <[email protected]>
Signed-off-by: FeriVOQ <[email protected]>
|
Could somebody check what's wrong?? |
|
Hello @ferivoq! Please make sure your version number has been bumped up! Version: |
Signed-off-by: FeriVOQ <[email protected]>
|
Could somebody merge pls if it's good? |
theusaf
changed the title
theusaf
requested changes
May 1, 2024
websites/A/AnimeDrive/metadata.json
Outdated
| "logo": "https://cdn.rcd.gg/PreMiD/websites/A/AnimeDrive/assets/logo.png", | ||
| "thumbnail": "https://cdn.rcd.gg/PreMiD/websites/A/AnimeDrive/assets/thumbnail.png", | ||
| "version": "1.0.2", | ||
| "logo": "https://cdn.discordapp.com/icons/702098578251841577/be50b5dbcb30bd99512b6df29284db0c.webp", |
There was a problem hiding this comment.
Logos should be 512x512px. You may need to upload the large image to another image source to avoid issues with query parameters with the current schema.
Suggested change
| "logo": "https://cdn.discordapp.com/icons/702098578251841577/be50b5dbcb30bd99512b6df29284db0c.webp", | |
| "logo": "https://i.imgur.com/VlBtvJo.png", |
Signed-off-by: FeriVOQ <[email protected]>
|
If it's good can you merge? @theusaf |
theusaf
approved these changes
May 2, 2024
Bas950
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added support so know you can see how much is left from an Anime.
Added hungarian translation to the metadata.json and the iframe things.
Acknowledgements
yarn formatScreenshots
Proof showing the creation/modification is working as expected