Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Writers Duet): add presence #8322

Merged
merged 9 commits into from
Apr 29, 2024
Merged

feat(Writers Duet): add presence #8322

merged 9 commits into from
Apr 29, 2024

Conversation

ION606
Copy link
Contributor

@ION606 ION606 commented Apr 28, 2024

Description

Acknowledgements

Screenshots

image

Proof showing the creation/modification is working as expected

@ION606
Copy link
Contributor Author

ION606 commented Apr 28, 2024

from #7798

@theusaf theusaf changed the title feat(Writers Duet): adding presence feat(Writers Duet): add presence Apr 28, 2024
Copy link
Member

@theusaf theusaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit low-quality. Consider adding other parts of the page (blog, etc) to the presence.

websites/W/WriterDuet/metadata.json Outdated Show resolved Hide resolved
Co-authored-by: Daniel Lau <[email protected]>
Signed-off-by: ION606 <[email protected]>
@ION606
Copy link
Contributor Author

ION606 commented Apr 28, 2024

It's a bit low-quality. Consider adding other parts of the page (blog, etc) to the presence.

I just added what the issue asked for

@theusaf theusaf requested a review from Bas950 April 28, 2024 19:32
@Bas950
Copy link
Member

Bas950 commented Apr 29, 2024

Please add support for other pages

@ION606 ION606 requested a review from theusaf April 29, 2024 04:07
@theusaf theusaf enabled auto-merge (squash) April 29, 2024 17:27
@theusaf theusaf merged commit fa68fac into PreMiD:main Apr 29, 2024
3 checks passed
@ION606 ION606 deleted the writersduet branch May 1, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Writer Duet | writerduet.com
3 participants