Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/run eslint #100

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Feature/run eslint #100

merged 4 commits into from
Dec 14, 2023

Conversation

ashmit-coder
Copy link
Contributor

Fixes: #89
Ran the linter and also added a worklfow for the same
refrence: #94

@ashmit-coder
Copy link
Contributor Author

Hey @PradyumnaKrishna i added the workflow as you demanded

@ashmit-coder @PradyumnaKrishna
Update .github/workflows/run_eslint.yml
e52ac10 
Co-authored-by: Pradyumna Krishna <[email protected]>
Signed-off-by: Ashmit Jagtap  <[email protected]>
@ashmit-coder
Copy link
Contributor Author

@PradyumnaKrishna done with the changes

ashmit-coder
ashmit-coder commented Dec 14, 2023
View reviewed changes
Copy link
Contributor Author

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completed changes as mentioned

@PradyumnaKrishna PradyumnaKrishna merged commit 8039546 into PradyumnaKrishna:main Dec 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PradyumnaKrishna PradyumnaKrishna PradyumnaKrishna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run ESLint
2 participants
@ashmit-coder @PradyumnaKrishna