Bug fix for Import-PSGetRepository in Windows PS

[alerickson]

PR Summary

Bug fix for Import-PSGetRepository in Windows PowerShell not actually porting PowerShellGet v2 repositories to PSResourceGet. .count property does not work on the object returned in Windows PS (however it does in PS 6+). Simple change to check if the $repos returned is empty or not checks to see whether repositories need to be transferred over.

PR Context

Resolves #1442

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Documentation needed
    • Issue filed:
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary.

[kborowinski]

@alerickson: The issue is also here, as $repos.Count will return $null on PowerShell 5.1, when only one repository was found, and therefore the verbose message will be misleading - "VERBOSE: Selected NuGet repositories" .

I suggest changing it either to @($repos).Count, or maybe, to make the code cleaner, we should assign the repos count to a variable, like this;

...
$reposCount = @(repos).Count
Microsoft.PowerShell.Utility\Write-Verbose ('Selected {0} NuGet repositories.' -f $reposCount)

if ($reposCount) {
...

or just convert the filtering result to an array:

...
$repos = @(
    $PSGetRepositories.Values |
        Microsoft.PowerShell.Core\Where-Object {$_.PackageManagementProvider -eq 'NuGet'-and $_.Name -ne 'PSGallery'} |
        Microsoft.PowerShell.Utility\Select-Object Name, Trusted, SourceLocation
)

Microsoft.PowerShell.Utility\Write-Verbose ('Selected {0} NuGet repositories.' -f $repos.Count)

if ($repos.Count) {
...

[alerickson]

Thanks for catching that, let me fix that

[kborowinski]

Sorry @alerickson for nitpicking, but do we need extra space here? And wouldn't it look better if the $PSGetRepositories.Values got moved to a new line instead:

$repos = @(
    $PSGetRepositories.Values |

[kborowinski]

LGTM! Thanks! 🎉