Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change how to pass STDIN input via --file, rename other args #601

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Change how to pass STDIN input via --file, rename other args #601

merged 6 commits into from
Dec 3, 2024

Conversation

SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Nov 26, 2024 •
edited
Loading

PR Summary

  • Remove automatic reading of STDIN as it can block in environments that redirect STDIN but never send input like ADO Pipelines
  • Use convention --file - to indicate to read from STDIN, updated CLI help
  • Rename --format to --output-format to use -f to only mean --file, shorthand is now -o
  • Rename --document to --input to have it consistent for config and resource invocation
  • Rename --trace-format shorthand to -t
  • Lots of test changes due to the parameters change

PR Context

Fix #588

@SteveL-MSFT SteveL-MSFT added this to the 3.0-Approved milestone Nov 26, 2024
@SteveL-MSFT SteveL-MSFT marked this pull request as ready for review November 27, 2024 00:25
tgauth
tgauth approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@tgauth tgauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anmenaga
anmenaga approved these changes Dec 2, 2024
View reviewed changes
dsc/src/subcommand.rs Show resolved Hide resolved
@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Dec 3, 2024
Merged via the queue into PowerShell:main with commit a6db74b Dec 3, 2024
4 checks passed
@SteveL-MSFT SteveL-MSFT deleted the file-stdin branch December 3, 2024 00:47
@SteveL-MSFT SteveL-MSFT mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgauth tgauth tgauth approved these changes

@anmenaga anmenaga anmenaga approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

Assignees
No one assigned
Labels
Backport-Done Doc-Impact
Projects
None yet
Milestone
3.0-Approved
Development

Successfully merging this pull request may close these issues.

DSC on Azure Pipelines Ubuntu
3 participants
@SteveL-MSFT @anmenaga @tgauth