Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround script resource parameter validation #237

Closed

Conversation

mgreenegit
Copy link
Member

Resolves #236

Calling get-dscresources is a performance hit, so we might want to consider refactoring so we call it as few times as possible across operations
@mgreenegit
Copy link
Member Author

mgreenegit commented Oct 18, 2023

Calling Get-DscResource is a performance hit. We could optimize and populate more information to cache, if Path and ImplementationDetail are the only two additional properties we need?

@mgreenegit mgreenegit closed this Oct 19, 2023
@mgreenegit mgreenegit reopened this Oct 19, 2023
@SteveL-MSFT SteveL-MSFT requested a review from anmenaga October 20, 2023 03:24
@mgreenegit mgreenegit closed this Oct 24, 2023
@mgreenegit mgreenegit reopened this Oct 24, 2023
Copy link
Collaborator

@anmenaga anmenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor update needed.

powershellgroup/powershellgroup.resource.ps1 Outdated Show resolved Hide resolved
powershellgroup/powershellgroup.resource.ps1 Outdated Show resolved Hide resolved
@mgreenegit mgreenegit closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script based resources do not enforce schema validation
2 participants