Replace reflect.SliceHeader with unsafe.Slice #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #20
This PR fixes the
go vet
warning caused by the use ofreflect.SliceHeader()
by replacing it withunsafe.Slice()
.I'm not 100% this actually works as desired, as the
unsafe
andreflect
libraries both feel like voodoo to me. There don't seem to be tests in this area, but maybe I missed them?This requires a version bump for Go:
This is probably reasonable, since Go supports two major releases at a time:
https://go.dev/doc/devel/release#policy
And we're on Go 1.21, meaning that anything older than Go 1.19 is unsupported.
OTOH, I can see how dropping support for language release from less than 3 years ago could seem a bit aggressive. ¯\_(ツ)_/¯