Update FilterDateTimePicker.php #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```Filter::datetimepicker()``` has no difference with ```Filter::datepicker()```
With this change there is a time option with Flatpickr
Actually, you should also 'disable' the ```enableTime``` option in ```config/livewire-powergrid.php``` to let these two differ from each other.
To also enable seconds with the datetimepicker you can use:
```
Filter::datetimepicker('created_at')->params(['enableSeconds' => true])
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡ PowerGrid - Pull Request
Welcome and thank you for your interest in contributing to our project!. You must use this template to submit a Pull Request or it will not be accepted.
Motivation
Description
Filter::datetimepicker()has no difference withFilter::datepicker()With this change there is a time option with Flatpickr
Actually, you should also 'disable' the
enableTimeoption inconfig/livewire-powergrid.phpto let these two differ from each other.To also enable seconds with the datetimepicker you can use:
Related Issue(s): none.
Documentation
This PR requires Documentation update?