-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to mysqli #55
Switch to mysqli #55
Conversation
Mysqli driver is now mostly working. I'm able to load the site, browse it and more. But I can't yet make changes to posts or create new posts. Editing via appearance also fails. The error log contains this.
Additionally i'm getting errors about sequences |
I was able to switch themes fine, but it gave errors
|
Here's another hint:
it looks like something is wrong with |
I think inserts aren't working properly which is what is causing the majority of these issues |
The issue was the connection was not shared between the insert and the sequence value call. Changing all functions to pass by reference, updating the global connection more frequently and changing all functions to prefer passed $connection over global fixed the issue. From what I can see everything is now working correctly but many parts of the driver such as prepared statements aren't implemented. I'm going to merge this, tag a new release and open issues for each function not implemented in the driver. |
For compatibility with WP 6.4 we must implement mysqli functions instead of mysql functions in our driver class
See:
#54