feat: keyboard shortcut component #26658
Merged
+24
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Comment on lines
+51
to
+57
| const arrowKey: Partial<Record<HotKeyOrModifier, true>> = {} | ||
| if (direction === 'forward') { | ||
| arrowKey.arrowright = true | ||
| } | ||
| if (direction === 'backward') { | ||
| arrowKey.arrowleft = true | ||
| } |
There was a problem hiding this comment.
I can see the react-scan thingy flashing in horror in front of my eyes, lol. I suggest using useMemo :)
There was a problem hiding this comment.
It'd be ideal if we could simply say something like arrowRight={direction === 'forward'} in the KeyboardShortcut component, but we'd need to tweak the inner implementation to achieve that
rafaeelaudibert
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't know the keyboard shortcut component exists...
But it's much prettier than the manual shortcut advice we gave in tooltips before, so let's use it