fix(data-warehouse): Use distinct_id field if present

[lcswillems]

Problem

I have a distinct_id field in my data warehouse table but this field is not used in order to prefill "Distinct ID field".

"Distinct ID field" is prefilled with "id" field. However, "id" doesn't corrspond to a user unique identifier, it corresponds to a row unique identifier, and so I really don't want "id" to be used for "Distinct ID field".

So each time I need to change "Distinct ID field" to use the field "distinct_id" of my table. This is very cumbersome and error prone. I have maybe 20 different insights where I need to change each time the "Distinct ID field".

Closes #26631

Changes

Use "distinct_id" field as a default for "Distinct ID field". And if it doesn't exist, falls back to "id".

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

I didn't test.

[lcswillems]

@Twixes I've tried to be way more precise in the issue and description of the PR. Is there anything more I should do?

Also, do you have an idea how fast this PR could be reviewed? This is very cumbersome and error-prone, and the PR should be very straightforward.

[Gilbert09]

@Twixes I've tried to be way more precise in the issue and description of the PR. Is there anything more I should do?

Also, do you have an idea how fast this PR could be reviewed? This is very cumbersome and error-prone, and the PR should be very straightforward.

Thanks for adding this in! I've approved the CI checks, once they all pass I'll get this merged in

[lcswillems]

@Gilbert09 Thanks for the review! I've fixed the formatting. However, there is a Cypress test failing but I've no clue how to reproduce it locally and the CI only runs when you trigger it. How could I help fixing the last failing job?

[Gilbert09]

@Gilbert09 Thanks for the review! I've fixed the formatting. However, there is a Cypress test failing but I've no clue how to reproduce it locally and the CI only runs when you trigger it. How could I help fixing the last failing job?

Thanks for fixing it. I'll keep an eye on the cypress tests - 99% of the time the failures are just flakes, and so I'll just restart them

[lcswillems]

@Gilbert09 It seems that all the checks have passed! 🥳

[lcswillems]

@Gilbert09 Thank you very much for the fast review and the merge! Do you have an idea when this fix should go in production?

[Gilbert09]

@Gilbert09 Thank you very much for the fast review and the merge! Do you have an idea when this fix should go in production?

@lcswillems It went live about 10 mins ago 🥳

[lcswillems]

@Gilbert09 Indeed! ❤️ Thank you so much for the responsiveness!!