Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdp): default to mock HTTP requests disabled #26632

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

MarconLP
Copy link
Member

@MarconLP MarconLP commented Dec 4, 2024

Changes

  • updated Supports templating link
  • renamed mock toggle to Mock out HTTP requests and set the default to false

Haven't added a big warning since sending a real request seems what most people expect and Segment's custom function testing menu doesn't have any warnings as well, but happy to revisit this point.
2024-12-04 at 09 34 27@2x

Does this work well for both Cloud and self-hosted?

How did you test this code?

@MarconLP MarconLP requested a review from a team December 4, 2024 08:35
@MarconLP MarconLP enabled auto-merge (squash) December 4, 2024 08:46
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@MarconLP MarconLP merged commit 3063a39 into master Dec 4, 2024
97 checks passed
@MarconLP MarconLP deleted the hog-function-experience branch December 4, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants