chore(data-warehouse): Allowed saving of views without querying again #26580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gilbert09
commented
Dec 2, 2024
| @@ -188,6 +188,7 @@ function InternalDataTableVisualization(props: DataTableVisualizationProps): JSX | |||
| <> | |||
| <HogQLQueryEditor | |||
| query={query.source} | |||
| queryResponse={response ?? undefined} | |||
There was a problem hiding this comment.
Not my finest hour, but I wasn't expecting the "saved query" functionality to be tied to the HogQLQueryEditor component. Not sure on a better way to do this without tearing apart this component and logic 🤷
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
9223372036854775807)Does this work well for both Cloud and self-hosted?
Yup
How did you test this code?
Unit tests + running materialisation locally