fix(web-analytics): Use None, not Constant(value=None) #26509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
changed the title
robbie-c
force-pushed
the
fix/set-none-not-constant-null
branch
2 times, most recently
from
6111bf0
to
0a55444
Compare
robbie-c
force-pushed
the
fix/set-none-not-constant-null
branch
from
16d558f
to
456a163
Compare
rafaeelaudibert
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If there was another bug, this pattern could lead to us adding NULLs to our queries, rather than throwing an error while constructing a query. The former could silently result in long-running queries which would have a negative impact on the entire clickhouse cluster, whereas the latter would only affect this query and be easily caught in tests.
This other bug happened, see https://posthog.slack.com/archives/C076R4753Q8/p1732724606064399, and was fixed, but let's get rid of this pattern regardless
Changes
Change this web analytics query to use a python None to show the absence of a conversion goal expression, rather than a hogql NULL
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Existing tests pass