fix(lemon): remove buggy delay from _onBlur for LemonInputSelect

[havenbarnes]

Problem

Addresses issue described here: https://posthoghelp.zendesk.com/agent/tickets/20603

The problem: When clicking on an item from the popover which does not match the text input, the delayed _onBlur typically runs after the _onActionItem, reverting the selection back as can be seen in the Loom

Note - currently with the delay, this is a race condition. However when we remove the delay, the click action runs the _onActionItem, and because the popover is present during the click, the _onBlur will then go into its early return condition if (popoverFocusRef.current) {, which closes the popover, focuses the text input, and does not try to set any state values, which feels like the exact desired behavior

Given the deleted comment, I also tested all sorts of clicks in or around the popover, opening other popovers, etc and I can not find any adverse effects of removing this delay, but I'm wondering if @benjackwhite has any thoughts here as he added the delay initially when creating this component!

Changes

Remove the setTimeout wrapping _onBlur for LemonInputSelect

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

https://www.loom.com/share/ec54ef15771749b98d5ae11354cbb496

[havenbarnes]

@benjackwhite I know it's a deep cut from a while ago but curious if you remember any context around // We need to add a delay as a click could be in the popover or the input wrapper which refocuses 😃

[github-actions]

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged

Filename	Size
frontend/dist/toolbar.js	1.11 MB

_{compressed-size-action}

[posthog-bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[posthog-bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[dmarticus]

Seems fine and safe to me, but good call asking Ben for original context, and I'd wait to hear from him before shipping if this can wait a few days – it doesn't look like this is urgently affecting the customer, so we should be okay to be a bit cautious.

[posthog-bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[posthog-bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[posthog-bot]

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

• chromium: 0 added, 4 modified, 0 deleted (diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[benjackwhite]

Oooh i hope this doesn't break anything... It was too long ago for me to know why this mattered but be aware if it does break it might be a very obscur change so please test heavily

[Twixes]

I remember which case this change affects negatively. With the delay, clicking away from the LemonInputSelect immediately adds the current input as a value, see on master:

This is no longer true on this branch. Without the delay, two clicks are needed, which is not that smooth:

[Twixes]

I think this is fine though

[havenbarnes]

I remember which case this change affects negatively. With the delay, clicking away from the LemonInputSelect immediately adds the current input as a value, see on master:

This is no longer true on this branch. Without the delay, two clicks are needed, which is not that smooth:

That's interesting thanks for the callout! I feel like since there's an explicit "Add <typed_text>` button, this is a pretty good tradeoff as-is; losing one bit of convenience, but fixing a quite annoying and finicky bug. Regardless, I'll timebox and see if I can achieve both!

[havenbarnes]

@Twixes thanks for the callout there - was able to get the "click outside popover adds custom value" functionality back as well: https://www.loom.com/share/ec54ef15771749b98d5ae11354cbb496 !

[posthog-bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[posthog-bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[Twixes]

Perfect 🙌