feat(flags): add GET feature_flags/:id/status for determining flag staleness #26340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct-stale-flags
…ct-stale-flags
…ct-stale-flags
…ct-stale-flags
…ct-stale-flags
…ct-stale-flags
…ct-stale-flags
…ct-stale-flags
… into detect-stale-flags
dmarticus
reviewed
Nov 26, 2024
Co-authored-by: Dylan Martin <[email protected]>
Co-authored-by: Dylan Martin <[email protected]>
…ct-stale-flags
…ct-stale-flags
…ct-stale-flags
…ct-stale-flags
…ct-stale-flags
… into detect-stale-flags
…ct-stale-flags
… into detect-stale-flags
dmarticus
reviewed
Dec 4, 2024
There was a problem hiding this comment.
API design looks fine and idiomatic; love the tests; only have some feedback on what feels like an abstraction collision between a flag being "enabled" | "disabled" vs enabled with a status. I want to do a better job modeling the different between flags that are enabled vs disabled vs stale vs inactive (especially since I think it'd be cool for folks to just disable flags that are stale and have that "just work", if possible).
dmarticus
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This serves as a starting point for #16497
By hitting this new endpoint in the Feature Flag > Usage tab, we can show users when their flag isn't being used anymore and is ripe for deletion from Posthog AND in their codebase. Eventually, we can use this status checking logic as a way to automate the archival of flags or give users helpful hints about flag-related tech debt in general
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?