Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor-3000): add visualization tab #26268

Merged
merged 84 commits into from
Dec 3, 2024
Merged

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Nov 19, 2024

Problem

Changes

  • bring back visualization ability on new editor tab
Screenshot 2024-12-02 at 3 04 29 PM

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@EDsCODE EDsCODE linked an issue Nov 26, 2024 that may be closed by this pull request
26 tasks
@EDsCODE EDsCODE removed a link to an issue Nov 26, 2024
26 tasks
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

Base automatically changed from dw-editor-visualization to master December 2, 2024 15:36
An error occurred while trying to automatically change base from dw-editor-visualization to master December 2, 2024 15:36
@EDsCODE EDsCODE marked this pull request as ready for review December 2, 2024 15:51
@posthog-bot
Copy link
Contributor

Hey @EDsCODE! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@@ -0,0 +1,421 @@
import 'react-data-grid/lib/styles.css'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get that we're just dropping this in from existing code. Still, we need to replace the current editor ASAP - having multiple versions of this code will cause nightmares when people update existing BI stuff without knowing this exists.

@EDsCODE EDsCODE merged commit 8b60590 into master Dec 3, 2024
96 checks passed
@EDsCODE EDsCODE deleted the dw-editor-visualization-2 branch December 3, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants