chore: upgrade rrweb for playback #21368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
commented
Apr 5, 2024
Comment on lines
+9
to
+12
| + onError: (e) => { | ||
| + // maintain the existing behaviour of throwing if no handler is provided | ||
| + throw e; | ||
| + }, |
There was a problem hiding this comment.
Very difficult to parse this patch but it's just this change and adding a try / catch
daibhin
commented
Apr 5, 2024
Comment on lines
+518
to
+520
| + } catch (error) { | ||
| + this.config.onError(error); | ||
| } |
There was a problem hiding this comment.
End of the try / catch
daibhin
commented
Apr 5, 2024
| - id: lastPosition.id, | ||
| - debugData: d, | ||
| - }; | ||
| + try { |
|
Size Change: 0 B Total Size: 824 kB ℹ️ View Unchanged
|
marandaneto
reviewed
Apr 8, 2024
marandaneto
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Connected to PostHog/posthog-js#1115
Changes
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Ensured replays (including canvas playback) still works