Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nit pick log message #997

Merged
merged 3 commits into from
Feb 6, 2024
Merged

chore: nit pick log message #997

merged 3 commits into from
Feb 6, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Feb 6, 2024

i was ill and missed a review on #993 ... rather than comment on a merged pr, i'll propose this here, which we can accept or not as if it was part of the review 😊

we log something as an error, but we also fix the thing immediately.

instead let's log it as a warning - since there's no action needed really - and tell them we've fixed it


Fascinatingly... we don't run the functional tests locally... I haven't fixed them, and they still pass even though they're now wrong

Copy link

github-actions bot commented Feb 6, 2024

Size Change: +136 B (0%)

Total Size: 774 kB

Filename Size Change
dist/array.full.js 181 kB +34 B (0%)
dist/array.js 123 kB +34 B (0%)
dist/es.js 123 kB +34 B (0%)
dist/module.js 123 kB +34 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.1 kB
dist/recorder-v2.js 105 kB
dist/recorder.js 58.6 kB
dist/surveys.js 48.8 kB

compressed-size-action

@pauldambra pauldambra marked this pull request as ready for review February 6, 2024 09:39
@pauldambra pauldambra requested a review from robbie-c February 6, 2024 09:39
@robbie-c robbie-c merged commit 560c63a into main Feb 6, 2024
16 checks passed
@robbie-c robbie-c deleted the chore/nit-pick-log-message branch February 6, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants