fix: Missing typescript issue check #981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +70 B (0%) Total Size: 767 kB
ℹ️ View Unchanged
|
|
weird there's no error for me... I can run what error do you get? |
pauldambra
approved these changes
Jan 31, 2024
| @@ -619,7 +619,7 @@ export class SessionRecording { | |||
| clearInterval(this._fullSnapshotTimer) | |||
| } | |||
|
|
|||
| this._fullSnapshotTimer = setInterval(() => { | |||
| this._fullSnapshotTimer = window?.setInterval(() => { | |||
There was a problem hiding this comment.
feels like a safe enough change so 🚢
but definitely be good to understand why this works in CI, and on my machine, but not on yours
There was a problem hiding this comment.
That's surprising... I will clear my local node_modules or something and try again...
There was a problem hiding this comment.
ah ha. The error went away!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Locally
pnpm builderrors with a TS issue. Trying to recreate on the CI so we can fix and figure out why it wasn't caught...Outcome: Couldn't figure out why it wasn't working but swapping to the window's setTimeout fixed it...
Checklist