fix: set the session id as soon as it changes #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -36 B (0%) Total Size: 756 kB
ℹ️ View Unchanged
|
marandaneto
reviewed
Jan 11, 2024
marandaneto
approved these changes
Jan 11, 2024
pauldambra
commented
Jan 11, 2024
| @@ -406,7 +407,7 @@ export class SessionRecording { | |||
| reason: 'user activity', | |||
| type: event.type, | |||
| }) | |||
| this._tryTakeFullSnapshot() | |||
| returningFromIdle = true | |||
There was a problem hiding this comment.
as I added tracking of full snapshots in the tests it became clear there were routes through the code where we might take two full snapshots
(despite this change being about avoiding taking none full snapshots I tidied this up at the same time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've a bug where the full snapshot is missing at the start of some recordings.
I think this fixes it - certainly resetting sessions locally I couldn't get it to trigger any more.