-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow setting asset_host to not load assets from api_host #951
Conversation
Hey @frankh! 👋 |
f9a769b
to
18f4f6f
Compare
Size Change: +5.03 kB (+1%) Total Size: 763 kB
ℹ️ View Unchanged
|
18f4f6f
to
72c94ba
Compare
72c94ba
to
7b721c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't run it but looks good to me :)
suggested duplicating some comments onto the type definition so we can have slightly nicer intellisense
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Co-authored-by: Paul D'Ambra <[email protected]>
Co-authored-by: Paul D'Ambra <[email protected]>
Changes
...
Checklist