Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow setting asset_host to not load assets from api_host #951

Closed
wants to merge 4 commits into from

Conversation

frankh
Copy link
Contributor

@frankh frankh commented Jan 8, 2024

Changes

...

Checklist

@posthog-bot
Copy link
Collaborator

Hey @frankh! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@frankh frankh force-pushed the frank/config-setting-asset-host branch from f9a769b to 18f4f6f Compare January 8, 2024 13:45
Copy link

github-actions bot commented Jan 8, 2024

Size Change: +5.03 kB (+1%)

Total Size: 763 kB

Filename Size Change
dist/array.full.js 179 kB +1.26 kB (+1%)
dist/array.js 120 kB +1.25 kB (+1%)
dist/es.js 120 kB +1.25 kB (+1%)
dist/module.js 121 kB +1.25 kB (+1%)
dist/recorder.js 58.4 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12 kB
dist/recorder-v2.js 104 kB
dist/surveys.js 48.7 kB

compressed-size-action

@frankh frankh force-pushed the frank/config-setting-asset-host branch from 18f4f6f to 72c94ba Compare January 9, 2024 09:43
@frankh frankh changed the title Allow setting asset_host to not load assets from api_host feat: Allow setting asset_host to not load assets from api_host Jan 9, 2024
@frankh frankh force-pushed the frank/config-setting-asset-host branch from 72c94ba to 7b721c0 Compare January 15, 2024 16:18
@frankh frankh marked this pull request as ready for review January 15, 2024 16:18
@frankh frankh marked this pull request as draft January 15, 2024 16:19
@frankh frankh requested a review from timgl January 15, 2024 16:19
@frankh frankh requested a review from pauldambra January 16, 2024 14:19
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't run it but looks good to me :)

suggested duplicating some comments onto the type definition so we can have slightly nicer intellisense

@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

frankh and others added 2 commits January 25, 2024 15:27
Co-authored-by: Paul D'Ambra <[email protected]>
Co-authored-by: Paul D'Ambra <[email protected]>
@posthog-bot posthog-bot removed the stale label Jan 26, 2024
@benjackwhite benjackwhite deleted the frank/config-setting-asset-host branch January 31, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants