fix: allow rrweb to control full snapshots

[pauldambra]

Changes

In #847 we started taking a full snapshot every ten minutes. a common perf improvement. In long recordings we've seen seeking in replay perform poorly because we don't take full snapshots more than once in many recordings.

In #860 we reverted that because it was clashing with the full snapshots we were taking on return from idle.

It occurred to me #860 was the wrong change. If rrweb is taking snapshots on return from idle when checkoutEveryNms is set and that's what we want then we can remove our attempt to take a full snapshot on return from idle

TODO

This is tricky to test since we rely on full snapshots being taken when we return from idle (although I believe this is failing in many cases because we're trying to take the snapshot before rrweb is ready) and we rely on a full snapshot when we rotate the session id

So, we probably need an integration test for those two cases that show we capture two sessions each with a full snapshot

Checklist

• Tests for new code (see advice on the tests we use)
• Accounted for the impact of any changes across different browsers

[github-actions]

Size Change: -3.28 kB (0%)

Total Size: 752 kB

Filename	Size	Change
dist/array.full.js	176 kB	-821 B (0%)
dist/array.js	118 kB	-820 B (-1%)
dist/es.js	118 kB	-820 B (-1%)
dist/module.js	118 kB	-820 B (-1%)

ℹ️ View Unchanged

Filename	Size
dist/exception-autocapture.js	12 kB
dist/recorder-v2.js	104 kB
dist/recorder.js	58.4 kB
dist/surveys.js	48.7 kB

_{compressed-size-action}

[posthog-bot]

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

[pauldambra]

this isn't it... this just moves the clash of when to take the snapshot elsewhere