Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sanitize given api_host urls to not have a trailing slash #920

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

benjackwhite
Copy link
Collaborator

Changes

A user had issues loading the recorder.js and this was down to a trailing slash in the api_host.

We always expect it to be without the trailing slash so this change ensures that.

Checklist

@benjackwhite benjackwhite requested a review from a team December 5, 2023 08:07
Copy link

github-actions bot commented Dec 5, 2023

Size Change: +240 B (0%)

Total Size: 745 kB

Filename Size Change
dist/array.full.js 176 kB +60 B (0%)
dist/array.js 118 kB +60 B (0%)
dist/es.js 118 kB +60 B (0%)
dist/module.js 118 kB +60 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12 kB
dist/recorder-v2.js 104 kB
dist/recorder.js 58.4 kB
dist/surveys.js 41.5 kB

compressed-size-action

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Dec 5, 2023
@benjackwhite benjackwhite merged commit 445590b into master Dec 5, 2023
14 checks passed
@benjackwhite benjackwhite deleted the fix/clean-api-host branch December 5, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants