Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flags): Make sure we don't override flags when decide is disabled #911

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

neilkakkar
Copy link
Collaborator

Changes

Noticed thanks to a bug report that advanced_disable_feature_flags setting was emptying flags. The test didn't catch this because it was returning extra flags using a mocked decide response when it shouldn't :/

...

Checklist

@neilkakkar neilkakkar added the bump patch Bump patch version when this PR gets merged label Nov 23, 2023
@neilkakkar neilkakkar marked this pull request as ready for review November 23, 2023 12:39
Copy link

Size Change: +444 B (0%)

Total Size: 743 kB

Filename Size Change
dist/array.full.js 176 kB +111 B (0%)
dist/array.js 117 kB +111 B (0%)
dist/es.js 117 kB +111 B (0%)
dist/module.js 117 kB +111 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12 kB
dist/recorder-v2.js 104 kB
dist/recorder.js 58.4 kB
dist/surveys.js 41.5 kB

compressed-size-action

@neilkakkar neilkakkar merged commit 6d55b04 into master Nov 23, 2023
14 checks passed
@neilkakkar neilkakkar deleted the fix-decide-call branch November 23, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants