Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import nuxt composables from #imports #879

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

danielroe
Copy link
Contributor

Changes

This is a DX improvement when developing - we can avoid loading the entire barrel file at #app by using the new granular imports merged in nuxt/nuxt#23951.

Checklist

@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Collaborator

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

@danielroe
Copy link
Contributor Author

Hm.

@GalacticHypernova
Copy link

GalacticHypernova commented Dec 12, 2023

Bad bot, reopen this PR right this instant!

@GalacticHypernova
Copy link

@pauldambra perhaps you can merge this? There's no reason not to, it's a DX improvement with no downsides.

@pauldambra
Copy link
Member

Hey,

Coincidentally, we've just set up a bot so we don't miss external contributions like this... sorry for the silence!

I've never used nuxt. I'll need to checkout the playground example before and after just for a check.

@pauldambra pauldambra reopened this Dec 13, 2023
@pauldambra pauldambra removed the stale label Dec 13, 2023
@pauldambra
Copy link
Member

TestCafe is failing but that's ok since it's a fork and if this change can break the SDK (and I can't even imagine how it could) then I'd want to find out 🤣

Sorry again for missing this! Thanks for taking the time to update it

@pauldambra pauldambra merged commit 8422689 into PostHog:master Dec 13, 2023
7 of 10 checks passed
@danielroe danielroe deleted the app-import branch December 13, 2023 17:35
@danielroe
Copy link
Contributor Author

Not at all 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants