Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checkout every X minutes #860

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: checkout every X minutes #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/__tests__/extensions/replay/sessionrecording.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {
RECORDING_IDLE_ACTIVITY_TIMEOUT_MS,
RECORDING_MAX_EVENT_SIZE,
SessionRecording,
TEN_MINUTES_IN_MS,
} from '../../../extensions/replay/sessionrecording'

// Type and source defined here designate a non-user-generated recording event
Expand Down Expand Up @@ -400,7 +399,6 @@ describe('SessionRecording', () => {
plugins: [],
inlineStylesheet: true,
recordCrossOriginIframes: false,
checkoutEveryNms: TEN_MINUTES_IN_MS,
})
})

Expand Down
3 changes: 0 additions & 3 deletions src/extensions/replay/sessionrecording.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import {
const BASE_ENDPOINT = '/s/'

export const RECORDING_IDLE_ACTIVITY_TIMEOUT_MS = 5 * 60 * 1000 // 5 minutes
export const TEN_MINUTES_IN_MS = 10 * 60 * 1000
export const RECORDING_MAX_EVENT_SIZE = 1024 * 1024 * 0.9 // ~1mb (with some wiggle room)
export const RECORDING_BUFFER_TIMEOUT = 2000 // 2 seconds
export const SESSION_RECORDING_BATCH_KEY = 'recordings'
Expand Down Expand Up @@ -435,8 +434,6 @@ export class SessionRecording {
collectFonts: false,
inlineStylesheet: true,
recordCrossOriginIframes: false,
//take a full snapshot after every N ms
checkoutEveryNms: TEN_MINUTES_IN_MS,
}
// We switched from loading all of rrweb to just the record part, but
// keep backwards compatibility if someone hasn't upgraded PostHog
Expand Down
Loading