chore: type checking in one place makes bundle smaller #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2.55 kB (0%) Total Size: 723 kB
|
pauldambra
changed the title
daibhin
approved these changes
Oct 23, 2023
benjackwhite
approved these changes
Oct 23, 2023
benjackwhite
approved these changes
Oct 24, 2023
daibhin
reviewed
Oct 24, 2023
| BinaryExpression: function (node) { | ||
| // Check for `toString.call(obj) == '[object Boolean]'` | ||
| if ( | ||
| (node.operator === '==' || node.operator === '===') && |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#ShowerThoughts
We have ~60 instances of type checks which might be smaller in the final bundle if they all point at a function instead of doing the work...
Let's find out ......
Looks like array.js is 1% smaller