Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix bot user agent detection #840

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: Fix bot user agent detection #840

merged 1 commit into from
Oct 18, 2023

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Oct 18, 2023 •
edited
Loading

Changes

Looks like #788 broke this - removed the case insensitivity

toLowerCase is supported on IE11 https://caniuse.com/?search=tolowercase

Checklist

@robbie-c robbie-c changed the title Fix bot user agent detection fix: Fix bot user agent detection Oct 18, 2023
@robbie-c robbie-c marked this pull request as ready for review October 18, 2023 15:55
@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

Size Change: +252 B (0%)

Total Size: 725 kB

Filename Size Change
dist/array.full.js 177 kB +63 B (0%)
dist/array.js 118 kB +63 B (0%)
dist/es.js 118 kB +63 B (0%)
dist/module.js 118 kB +63 B (0%)
ℹ️ View Unchanged
Filename Size
dist/recorder-v2.js 95 kB
dist/recorder.js 58.3 kB
dist/surveys.js 39.4 kB

compressed-size-action

@robbie-c robbie-c force-pushed the fix-user-agent-detection branch from 95fab14 to eeef35f Compare October 18, 2023 15:57
pauldambra
pauldambra approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 thanks for fixing!

@robbie-c robbie-c force-pushed the fix-user-agent-detection branch from eeef35f to e72c373 Compare October 18, 2023 16:06
@robbie-c robbie-c added the bump minor Bump minor version when this PR gets merged label Oct 18, 2023
@robbie-c robbie-c merged commit b884051 into master Oct 18, 2023
11 checks passed
@robbie-c robbie-c deleted the fix-user-agent-detection branch October 18, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbie-c @pauldambra