Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make ratings start at 0 #834

Merged
merged 1 commit into from
Oct 17, 2023
Merged

chore: Make ratings start at 0 #834

merged 1 commit into from
Oct 17, 2023

Conversation

neilkakkar
Copy link
Collaborator

Changes

Not too happy with the data model here, but will wait to generalise it till we get more examples of ratings we want to support. See PostHog/posthog#18011 for demo.

This change does imply that existing NPS surveys will get the 0 added to them.

Also fixes some unrelated eslintrc issues. filter on a dictionary wasn't working correctly.
...

Checklist

@neilkakkar neilkakkar added the bump patch Bump patch version when this PR gets merged label Oct 16, 2023
@github-actions
Copy link

Size Change: +23 B (0%)

Total Size: 724 kB

Filename Size Change
dist/surveys.js 39.4 kB +23 B (0%)
ℹ️ View Unchanged
Filename Size
dist/array.full.js 177 kB
dist/array.js 118 kB
dist/es.js 118 kB
dist/module.js 118 kB
dist/recorder-v2.js 95 kB
dist/recorder.js 58.3 kB

compressed-size-action

@neilkakkar neilkakkar marked this pull request as ready for review October 17, 2023 09:32
@neilkakkar neilkakkar merged commit e85f2b3 into master Oct 17, 2023
12 checks passed
@neilkakkar neilkakkar deleted the survey-ratings branch October 17, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants