fix(surveys): Handle filtering on undefined #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -856 B (0%) Total Size: 708 kB
ℹ️ View Unchanged
|
neilkakkar
reviewed
Sep 26, 2023
src/posthog-surveys.ts
Outdated
| @@ -29,6 +29,9 @@ export class PostHogSurveys { | |||
|
|
|||
| getActiveMatchingSurveys(callback: SurveyCallback, forceReload = false) { | |||
| this.getSurveys((surveys) => { | |||
| if (!surveys) { | |||
There was a problem hiding this comment.
Since our end users using the API would face this annoying issue as well, I'd say we should always return an array from getSurveys, and add a test for this case :)
liyiy
changed the title
neilkakkar
reviewed
Sep 27, 2023
src/__tests__/surveys.js
Outdated
| @@ -101,6 +101,13 @@ describe('surveys', () => { | |||
| expect(given.instance._send_request).toHaveBeenCalledTimes(2) | |||
| }) | |||
|
|
|||
| it('getSurveys returns empty array if surveys are undefined', () => { | |||
| given('surveysResponse', () => ({ surveys: undefined })) | |||
There was a problem hiding this comment.
This occurs when the request errors out, which is why there's nothing in surveys. As in other cases, our API always returns an array.
Suggested change
| given('surveysResponse', () => ({ surveys: undefined })) | |
| given('surveysResponse', () => ({ status: 0 })) |
jurajmajerik
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
sentry error link
problem: Filtering on undefined surveys causes an error
Checklist