Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rotate test distinct id to avoid lagging partition #1595

Closed
wants to merge 3 commits into from

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Dec 11, 2024

Changes

No code changes, I'm just changing the distinct id that is used in test to avoid the lagging partition.

Obviously this is a quick band aid over a larger problem

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 11, 2024 1:54pm

@posthog-bot
Copy link
Collaborator

Hey @robbie-c! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@robbie-c robbie-c changed the title Rotate distinct id fix: Rotate test distinct id to avoid lagging partition Dec 11, 2024
Copy link

github-actions bot commented Dec 11, 2024

Size Change: 0 B

Total Size: 3.21 MB

ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/array.full.es5.js 260 kB
dist/array.full.js 364 kB
dist/array.full.no-external.js 362 kB
dist/array.js 178 kB
dist/array.no-external.js 176 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.48 kB
dist/main.js 179 kB
dist/module.full.js 364 kB
dist/module.full.no-external.js 362 kB
dist/module.js 178 kB
dist/module.no-external.js 177 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.3 kB
dist/tracing-headers.js 1.75 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@robbie-c robbie-c closed this Dec 12, 2024
@robbie-c robbie-c deleted the fix/rotate-test-distinct-id branch December 12, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants