feat: lazy load session recording #1588
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: -266 kB (-8.23%) ✅ Total Size: 2.97 MB
ℹ️ View Unchanged
|
pauldambra
commented
Dec 9, 2024
| @@ -825,7 +842,10 @@ describe('posthog core', () => { | |||
| posthog.sessionRecording = { | |||
| afterDecideResponse: jest.fn(), | |||
| startIfEnabledOrStop: jest.fn(), | |||
| } as unknown as SessionRecording | |||
| } as OnlyValidKeys< | |||
There was a problem hiding this comment.
interesting... i expected this change to highlight the incorrect setup here that the as unknown is hiding
pauldambra
commented
Dec 9, 2024
There was a problem hiding this comment.
need to add tests on the loader separately from the loaded file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move session recording entirely to lazy loaded not just the rrweb portions
tested locally and can still record
still need to figure out how to safely release this since it will be published to NPM before the new lazy bundle is available on the CDN