Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Don't create person profile when setting properties for flags #1586

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Dec 7, 2024

Changes

Remove the call to _requirePersonProcessing from setPersonPropertiesForFlags, as it doesn't need it

More context at https://posthog.slack.com/archives/C01MGUHFH6G/p1733511049244089

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Dec 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 7, 2024 5:37pm

Copy link
Contributor

@dmarticus dmarticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Robbie!

@robbie-c robbie-c added the bump patch Bump patch version when this PR gets merged label Dec 7, 2024
Copy link

github-actions bot commented Dec 7, 2024

Size Change: -700 B (-0.02%)

Total Size: 3.2 MB

Filename Size Change
dist/array.full.es5.js 259 kB -70 B (-0.03%)
dist/array.full.js 362 kB -70 B (-0.02%)
dist/array.full.no-external.js 361 kB -70 B (-0.02%)
dist/array.js 177 kB -70 B (-0.04%)
dist/array.no-external.js 175 kB -70 B (-0.04%)
dist/main.js 177 kB -70 B (-0.04%)
dist/module.full.js 362 kB -70 B (-0.02%)
dist/module.full.no-external.js 361 kB -70 B (-0.02%)
dist/module.js 177 kB -70 B (-0.04%)
dist/module.no-external.js 175 kB -70 B (-0.04%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.48 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.3 kB
dist/tracing-headers.js 1.75 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@robbie-c robbie-c merged commit a934d03 into main Dec 12, 2024
21 checks passed
@robbie-c robbie-c deleted the feature/dont-create-person-profile-when-setting-properties-for-flags branch December 12, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants