Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change lib import path from /lib/src/ to /lib #1554

Closed
wants to merge 2 commits into from

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Nov 26, 2024

Changes

Change tsconfig.json to have a root dir, this lets people import e.g. customizations from posthog-js/lib rather than posthog-js/lib/src which IMO is cleaner

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Nov 26, 2024 11:30am

@posthog-bot
Copy link
Collaborator

Hey @robbie-c! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@robbie-c robbie-c changed the title Change lib import path from /lib/src/ to /lib feat: Change lib import path from /lib/src/ to /lib Nov 26, 2024
Copy link

github-actions bot commented Nov 26, 2024

Size Change: +181 kB (+5.76%) 🔍

Total Size: 3.32 MB

Filename Size Change
dist/all-external-dependencies.js 218 kB +12 kB (+5.82%) 🔍
dist/array.full.es5.js 249 kB -5.67 kB (-2.23%)
dist/array.full.js 378 kB +20 kB (+5.58%) 🔍
dist/array.full.no-external.js 377 kB +19.9 kB (+5.58%) 🔍
dist/array.js 187 kB +15 kB (+8.68%) 🔍
dist/array.no-external.js 186 kB +14.9 kB (+8.67%) 🔍
dist/dead-clicks-autocapture.js 22.1 kB +7.79 kB (+54.33%) 🆘
dist/exception-autocapture.js 10.1 kB +704 B (+7.52%) 🔍
dist/external-scripts-loader.js 2.85 kB +562 B (+24.53%) 🚨
dist/main.js 188 kB +14.9 kB (+8.62%) 🔍
dist/module.full.js 378 kB +20 kB (+5.57%) 🔍
dist/module.full.no-external.js 377 kB +19.9 kB (+5.57%) 🔍
dist/module.js 187 kB +14.9 kB (+8.61%) 🔍
dist/module.no-external.js 186 kB +14.8 kB (+8.65%) 🔍
dist/recorder-v2.js 118 kB +3.61 kB (+3.15%)
dist/recorder.js 118 kB +3.61 kB (+3.15%)
dist/surveys-preview.js 59.1 kB +1.52 kB (+2.65%)
dist/surveys.js 64.8 kB +1.65 kB (+2.61%)
dist/tracing-headers.js 2.81 kB +1.06 kB (+60.59%) 🆘
dist/web-vitals.js 10.3 kB +8 B (+0.08%)

compressed-size-action

@robbie-c
Copy link
Member Author

This seems not a priority, so 🪓

@robbie-c robbie-c closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants