fix(surveys): Process feature_flag_keys on Survey object #1548
+143
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As part of adaptive survey collection, we introduced a new feature flag that the surveys component should use to filter out surveys to be shown to people.
The common pattern has become :
getActiveMatchingSurveys
Instead, this PR now uses the
feature_flag_keys
array to find the names of the feature flags to check in the survey component.With this change, one can just add a new flag to the
feature_flag_keys
in the Surveys API in posthog.com and the survey component will automatically pick it up.Checklist