fix: Don't use session storage in memory mode

[robbie-c]

Changes

We currently use sessionStorage even when the persistence is set to memory. This is a bug, which this PR fixes and adds some tests for.

Checklist

• Tests for new code (see advice on the tests we use)
• Accounted for the impact of any changes across different browsers
• Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
posthog-js	✅ Ready (Inspect)	Visit Preview	Nov 12, 2024 4:22pm

[github-actions]

Size Change: +720 B (+0.02%)

Total Size: 3.1 MB

Filename	Size	Change
dist/array.full.es5.js	253 kB	+72 B (+0.03%)
dist/array.full.js	355 kB	+72 B (+0.02%)
dist/array.full.no-external.js	354 kB	+72 B (+0.02%)
dist/array.js	170 kB	+72 B (+0.04%)
dist/array.no-external.js	169 kB	+72 B (+0.04%)
dist/main.js	171 kB	+72 B (+0.04%)
dist/module.full.js	355 kB	+72 B (+0.02%)
dist/module.full.no-external.js	354 kB	+72 B (+0.02%)
dist/module.js	170 kB	+72 B (+0.04%)
dist/module.no-external.js	169 kB	+72 B (+0.04%)

ℹ️ View Unchanged

Filename	Size
dist/all-external-dependencies.js	204 kB
dist/dead-clicks-autocapture.js	13 kB
dist/exception-autocapture.js	8.8 kB
dist/external-scripts-loader.js	2.19 kB
dist/recorder-v2.js	113 kB
dist/recorder.js	113 kB
dist/surveys-preview.js	56.7 kB
dist/surveys.js	62.1 kB
dist/tracing-headers.js	1.33 kB
dist/web-vitals.js	10.3 kB

_{compressed-size-action}

[daibhin]

Don't have full context on the why behind this change change but looks to do what it says in the test