-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web-analytics): Add flag to send server hash instead of distinct id #1490
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +8.99 kB (+0.28%) Total Size: 3.22 MB
ℹ️ View Unchanged
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
f8f92d5
to
bd9cf0c
Compare
566e2e7
to
1d859d2
Compare
b84f4f8
to
13545a0
Compare
08e32cc
to
71d5093
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments - although intrigued about the server side given I wasn't much aware of this 😅
74d0362
to
833d570
Compare
833d570
to
0afe187
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* PREVIEW - MAY CHANGE WITHOUT WARNING - DO NOT USE IN PRODUCTION | ||
* Sentinel value for distinct id, device id, session id. Signals that the server should generate the value | ||
* */ | ||
export const COOKIELESS_SENTINEL_VALUE = '$posthog_cklsh' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea for the future: store this kind of cross-repo setting in a global store to avoid them getting out of sync
Changes
Part of PostHog/posthog#25117
Main repo PR (currently WIP, this PR can be merged before that one) PostHog/posthog#25915
Everything is behind a config option with a dire warning, so this doesn't need to be final.
Checklist