-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade rrweb to alpha.17 #1488
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
+ const rootDomain = window.location.origin | ||
+ const stylesheetPath = href.replace(window.location.href, '') | ||
+ const potentialStylesheetHref = rootDomain + '/' + stylesheetPath | ||
+ const rootDomain = window.location.origin; | ||
+ const stylesheetPath = href.replace(window.location.href, ''); | ||
+ const potentialStylesheetHref = rootDomain + '/' + stylesheetPath; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No real difference here, just added ;
at the end of each line
Size Change: +1.57 MB (+54.38%) 🆘 Total Size: 4.46 MB
ℹ️ View Unchanged
|
that's my first thought too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weeeellllll, do i approve this or not.
it's way tidier since we lose the patches
it works locally, which is the definitive test to prove all is well
the bundled file is waaaaayyyyy bigger which would be nice to avoid
yep @daibhin comparing v16 and v17 built output includes things like
so pretty sure that postcss is being included |
Closing in favour of #1489 |
Changes
Following the big bump in #1276 which seems to have rolled out fine it is probably now worth moving to the latest version which has no scary changes.
Reapplied all patches
Best new feature is
dialog
element supportChecklist