Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't track heatmaps of toolbar #1152

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Conversation

benjackwhite
Copy link
Collaborator

Changes

We track interactions of the toolbar which can be pretty confusing, especially when you are first setting up and testing with it.

  • Check for if the element clicked is or is in the toolbar
  • If so ignore it

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite requested a review from pauldambra April 24, 2024 09:12
Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ❌ Failed (Inspect) Apr 24, 2024 11:31am

Copy link

github-actions bot commented Apr 24, 2024

Size Change: +668 B (0%)

Total Size: 974 kB

Filename Size Change
dist/array.full.js 233 kB +167 B (0%)
dist/array.js 130 kB +167 B (0%)
dist/es.js 130 kB +167 B (0%)
dist/module.js 131 kB +167 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.2 kB
dist/recorder-v2.js 108 kB
dist/recorder.js 108 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@benjackwhite benjackwhite changed the title fix: Don't track hatmaps of toolbar fix: Don't track heatmaps of toolbar Apr 24, 2024
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

(is closest supported in IE11?)

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Apr 24, 2024
@benjackwhite
Copy link
Collaborator Author

🚢

(is closest supported in IE11?)

Good point - it isn't so added a check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants