Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update nextjs project to have more realistic controls #1151

Merged
merged 23 commits into from
Apr 24, 2024

Conversation

benjackwhite
Copy link
Collaborator

@benjackwhite benjackwhite commented Apr 23, 2024

Changes

Makes the nextjs app more useful and deployable so we can test it

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Apr 24, 2024 11:17am

@posthog-bot
Copy link
Collaborator

Hey @benjackwhite! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link

github-actions bot commented Apr 23, 2024

Size Change: 0 B

Total Size: 973 kB

ℹ️ View Unchanged
Filename Size
dist/array.full.js 233 kB
dist/array.js 130 kB
dist/es.js 130 kB
dist/exception-autocapture.js 12.2 kB
dist/module.js 131 kB
dist/recorder-v2.js 108 kB
dist/recorder.js 108 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@benjackwhite benjackwhite marked this pull request as ready for review April 24, 2024 10:20
@benjackwhite benjackwhite merged commit 721a3d5 into main Apr 24, 2024
12 checks passed
@benjackwhite benjackwhite deleted the feat/personless-app branch April 24, 2024 11:36
@jurajmajerik
Copy link
Contributor

@benjackwhite, I've noticed you changed the "Developing with another project" section.

Just flagging that linking via pnpm doesn't work for me for some reason 🤔 Doing it the old way with yalc still works.

@benjackwhite
Copy link
Collaborator Author

@benjackwhite, I've noticed you changed the "Developing with another project" section.

Just flagging that linking via pnpm doesn't work for me for some reason 🤔 Doing it the old way with yalc still works.

Weird. I don't know what to say other than "works for me" :D Maybe a more detailed issue of what you tried and what didnt work and then I can take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants