chore: upgrade rrweb to alpha-13 #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +405 B (0%) Total Size: 973 kB
ℹ️ View Unchanged
|
daibhin
commented
Apr 22, 2024
| .map((text) => { | ||
| const n = text.node; | ||
| - if (n.parentNode.tagName === 'TEXTAREA') { | ||
| + if (n.parentNode && n.parentNode.tagName === 'TEXTAREA') { |
There was a problem hiding this comment.
Removed as fixed in rrweb-io/rrweb#1445
daibhin
commented
Apr 22, 2024
| + // The browser throws if the canvas is 0 in size | ||
| + // Uncaught (in promise) DOMException: Failed to execute 'createImageBitmap' on 'Window': The source image width is 0. | ||
| + // Assuming the same happens with height | ||
| + if (canvas.width === 0 || canvas.height === 0) return; |
There was a problem hiding this comment.
Removed as fixed in rrweb-io/rrweb#1422
daibhin
commented
Apr 22, 2024
| @@ -1,6 +1,6 @@ | |||
| diff --git a/es/rrweb/_virtual/_rollup-plugin-web-worker-loader__helper__browser__createBase64WorkerFactory.js b/es/rrweb/_virtual/_rollup-plugin-web-worker-loader__helper__browser__createBase64WorkerFactory.js | |||
There was a problem hiding this comment.
Worth noting this diff doesn't look 100% correct because GitHub is incorrectly parsing it. I used a text compare tool and only saw differences in spacing & the two changes intentionally removed
daibhin
commented
Apr 22, 2024
| @@ -1,1202 +0,0 @@ | |||
| diff --git a/es/rrweb/packages/rrweb/src/record/mutation.js b/es/rrweb/packages/rrweb/src/record/mutation.js | |||
There was a problem hiding this comment.
Hanging around since the last upgrade but not used / needed
marandaneto
approved these changes
Apr 22, 2024
This was referenced May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Upgrade to the latest rrweb with relevant patches reapplied