feat: Rename $process_person to $process_person_profile #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +32 B (0%) Total Size: 962 kB
ℹ️ View Unchanged
|
benjackwhite
approved these changes
Apr 16, 2024
| @@ -903,7 +903,7 @@ export class PostHog { | |||
| } | |||
|
|
|||
| // add person processing flag as very last step, so it cannot be overridden. process_person=true is default | |||
| properties['$process_person'] = this._hasPersonProcessing() | |||
| properties['$process_person_profile'] = this._hasPersonProcessing() | |||
There was a problem hiding this comment.
Not exactly to do with this PR - but what does this mean for legacy SDKs. Will we all of a sudden not process persons because there is no $process_person_profile property?
There was a problem hiding this comment.
That's a q for pipeline, but it should be that the absence of this property is treated as if it's true
There was a problem hiding this comment.
We default to true, the only thing that disables it is sending $process_person_profile=false
robbie-c
deleted the
feat/rename_process_person_to_process_person_profile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Rename $process_person to $process_person_profile
Checklist