chore: update docs on versioning #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
added
bump major
|
Size Change: 0 B Total Size: 961 kB ℹ️ View Unchanged
|
benjackwhite
approved these changes
Apr 16, 2024
benjackwhite
requested changes
Apr 16, 2024
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "posthog-js", | |||
| "version": "1.123.0", | |||
| "version": "1.123.1", | |||
There was a problem hiding this comment.
Wait - is this on purpose?
There was a problem hiding this comment.
Yeah, this commit has a tag attached to it, where I tried (and failed) to create a new release locally. Ideally should be merged.
There was a problem hiding this comment.
Ah wait we only have squash commits for this repo. Ah well it doesn't really matter - this PR is a minor bump wheras that was a patch
robbie-c
force-pushed
the
chore/update-docs-on-versioning
branch
from
e417001 to
448a5c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Following the instructions in the docs can get us in a weird state, so I changed them.
See internal thread https://posthog.slack.com/archives/C02GS3N743W/p1713272909176839?thread_ts=1713272170.819489&cid=C02GS3N743W
Checklist