Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove underscores from all functions #1140

Merged
merged 15 commits into from
Apr 18, 2024
Merged

fix: Remove underscores from all functions #1140

merged 15 commits into from
Apr 18, 2024

Conversation

benjackwhite
Copy link
Collaborator

@benjackwhite benjackwhite commented Apr 16, 2024

Changes

Underscores are bad because

  • Extra characters
  • It makes it hard to recognize if an import isn't needed as _ indicates to keep it even if unused.

@pauldambra I don't know if this is a worthy efffort or not but 🤷

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@posthog-bot
Copy link
Collaborator

Hey @benjackwhite! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link

github-actions bot commented Apr 16, 2024

Size Change: -8 B (0%)

Total Size: 973 kB

Filename Size Change
dist/array.full.js 233 kB -2 B (0%)
dist/array.js 130 kB -2 B (0%)
dist/es.js 130 kB -2 B (0%)
dist/module.js 131 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.2 kB
dist/recorder-v2.js 108 kB
dist/recorder.js 108 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@benjackwhite benjackwhite requested a review from pauldambra April 16, 2024 13:19
# Conflicts:
#	src/posthog-core.ts
@benjackwhite benjackwhite marked this pull request as ready for review April 16, 2024 13:24
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 90% convinced this PR is part of a social engineering attack by your evil twin Ramone White

I 100% did not read the changes

@benjackwhite
Copy link
Collaborator Author

giphy

# Conflicts:
#	src/autocapture.ts
#	src/posthog-core.ts
#	src/posthog-surveys.ts
@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Apr 18, 2024
# Conflicts:
#	src/extensions/segment-integration.ts
# Conflicts:
#	src/page-view.ts
#	src/posthog-core.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants