fix: continue recording after reset #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
changed the title
|
Size Change: +600 B (0%) Total Size: 951 kB
ℹ️ View Unchanged
|
daibhin
commented
Apr 12, 2024
| cy.posthog().then((ph) => { | ||
| ph.reset() | ||
| }) | ||
|
|
There was a problem hiding this comment.
I couldn't call ensureActivitySendsSnapshots() again here because two custom events were missing: 
I wasn't sure where these were coming from but assumed they may be fired after RRWeb initialises and hence won't fire a second time
There was a problem hiding this comment.
Let's alter that ensure or duplicate it so we can test for any snapshots maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Addresses https://posthog.com/questions/session-recordings-not-being-resumed-after-calling-posthog-restart
Because we rely on the
decideresponse to know whether session recording is enabled, we assume a falsey value when the persistent storage is cleared as part of theresetcall.This change sets up a listener
onSessionIdrotation that will re-establish the keys returned by the decide response. We need to re-register all keys otherwise things like the minimum session duration would not be available for the new session.The sampling decision for the new session is handled separately in the
_samplingSessionListenerChecklist