Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sampling typescript error #1129

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: sampling typescript error #1129

merged 1 commit into from
Apr 10, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Apr 10, 2024

Changes

Fixes #1105 (comment)

@daibhin daibhin requested a review from pauldambra April 10, 2024 16:07
@daibhin daibhin mentioned this pull request Apr 10, 2024
Merged
@daibhin daibhin added the bump patch Bump patch version when this PR gets merged label Apr 10, 2024
pauldambra
pauldambra approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beat me to it! thank you!

@github-actions GitHub Actions
Copy link

Size Change: 0 B

Total Size: 951 kB

ℹ️ View Unchanged
Filename Size
dist/array.full.js 226 kB
dist/array.js 127 kB
dist/es.js 128 kB
dist/exception-autocapture.js 12.2 kB
dist/module.js 128 kB
dist/recorder-v2.js 105 kB
dist/recorder.js 105 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@pauldambra pauldambra merged commit 78f530e into main Apr 10, 2024
12 checks passed
@pauldambra pauldambra deleted the dn-fix/sampling-tsc-error branch April 10, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daibhin @pauldambra