-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add person processing mode preview #1109
Conversation
Size Change: +2.25 kB (0%) Total Size: 947 kB
ℹ️ View Unchanged
|
5e3f2a8
to
c74dab0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a three-glasses-of-prosecco, saturday evening review, treat it accordingly 🤣
I've not really been following this project so I'm not 100% but I think this does the right thing
Yeah - working with optimizers is a pain for exactly this reason. |
Enable by setting
__preview_process_person
in configChanges
See PostHog/posthog.com#8098
$set
etc are not sent with personless events (no-op, they were only sent with identify afaict)identify
cannot be called if person mode isnever
Manual tests
Checklist
On this last one, the default person processing mode is
always
which is identical to the current behaviour