Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Default api host to us.i.posthog.com #1087

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Conversation

benjackwhite
Copy link
Collaborator

Changes

  • Change the default
  • Fix so that ui_host removes the .i. part

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Mar 15, 2024
@posthog-bot
Copy link
Collaborator

Hey @benjackwhite! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link

github-actions bot commented Mar 15, 2024

Size Change: +184 B (0%)

Total Size: 942 kB

Filename Size Change
dist/array.full.js 224 kB +46 B (0%)
dist/array.js 124 kB +46 B (0%)
dist/es.js 124 kB +46 B (0%)
dist/module.js 124 kB +46 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.1 kB
dist/recorder-v2.js 106 kB
dist/recorder.js 106 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@benjackwhite benjackwhite removed the stale label Apr 8, 2024
@benjackwhite benjackwhite merged commit 54957f0 into main Apr 8, 2024
13 checks passed
@benjackwhite benjackwhite deleted the fix/default-host branch April 8, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged waiting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants