chore: remove cypress log noise #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Mar 15, 2024
| @@ -287,7 +287,7 @@ describe('Event capture', () => { | |||
|
|
|||
| // the code below is going to trigger an event capture | |||
| // we want to assert on the request | |||
| cy.intercept('POST', '**/e/*', async (request) => { | |||
There was a problem hiding this comment.
as far as I could tell from testing
**/blah matches something/blah but not /blah so wasn't matching all requests the tests were making
pauldambra
commented
Mar 15, 2024
Comment on lines
+13
to
+14
| cy.intercept('POST', '/e/*', { status: 1 }).as('capture') | ||
| cy.intercept('POST', '/ses/*', { status: 1 }).as('session-recording') |
There was a problem hiding this comment.
json response so that rate limiter doesn't log an error
pauldambra
commented
Mar 15, 2024
Comment on lines
+25
to
+27
| cy.readFile('dist/array.full.js.map').then((body) => { | ||
| cy.intercept('/static/array.full.js.map', { body }) | ||
| }) |
There was a problem hiding this comment.
map file intercepts so we're serving the correct file when the browser requests it and not complaining in the logs
|
Size Change: 0 B Total Size: 941 kB ℹ️ View Unchanged
|
daibhin
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lifting these changes out of #1083
it was really hard to debug failing cypress tests because we had lots of log warnings and errors around our request interceptors missing requests or not returning expected responses...
well, not any more